Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11727 )
Change subject: [location_awareness] Add ts location to TSInfoPB ...................................................................... Patch Set 6: (1 comment) Looks good, just one small nit. http://gerrit.cloudera.org:8080/#/c/11727/6/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/11727/6/src/kudu/integration-tests/table_locations-itest.cc@272 PS6, Line 272: req.set_max_returned_locations(3); nit: if the sub-scenario verifies just very first location, why to ask for 3 locations? Maybe, set max_returned_locations to 1? -- To view, visit http://gerrit.cloudera.org:8080/11727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259 Gerrit-Change-Number: 11727 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 25 Oct 2018 02:29:11 +0000 Gerrit-HasComments: Yes
