Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 )
Change subject: [client] expose location via internal API ...................................................................... Patch Set 7: (1 comment) Looks good: just one small nit. http://gerrit.cloudera.org:8080/#/c/11679/7/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: http://gerrit.cloudera.org:8080/#/c/11679/7/src/kudu/client/meta_cache.h@109 PS7, Line 109: KUDU_NO_EXPORT nit: I think this extra attribute isn't needed: the whole RemoteTabletServer class is in the kudu::client::internal namespace which neither externally exposed in any public API header file nor exported from the kudu_client library. -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 7 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 25 Oct 2018 04:16:24 +0000 Gerrit-HasComments: Yes
