Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 )
Change subject: [location_awareness] Add ts location to both client and internal client ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG@7 PS2, Line 7: Add ts location to both client and internal client > That make sense, but then I don't think you need to expose location() in cl Probably, that has already been discussed, and if so, I just want to have it in the review as well. It seems the idea was to use it in https://gerrit.cloudera.org/#/c/11422/11/src/kudu/tools/ksck_remote.cc@487 Is that acceptable to have it exposed in this patch or we want to have a separate patch with exposing the location via kudu::client::KuduTabletServer API (not exported, though)? Or another alternative would be not exposing the location via a public method of KuduTabletServer (but in internal-only API); instead, befriend RemoteKsckCluster and access the location field in src/kudu/tools/ksck_remote.cc via the KuduTabletServer::Data class? Adar, any preference on the items above? -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 2 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 23 Oct 2018 20:24:10 +0000 Gerrit-HasComments: Yes
