Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11679 )
Change subject: [location_awareness] Add ts location to both client and internal client ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11679/2//COMMIT_MSG@7 PS2, Line 7: [location_awareness] Add ts location to both client and internal client > Thanks, Adar and Alexey for the suggestions! One thing I'm not very clear, Ah, it seems a typo in my last comment was the source of the confusion. I meant '[client] expose location in KuduTabletServer via private API'. Maybe, a better wording might be: '[client] expose location via internal API' And then add the detailed description. And yes, since the location is needed for both KuduTabletServer and RemoteTabletServer, it's needed for both, I think. -- To view, visit http://gerrit.cloudera.org:8080/11679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib92cc6806073d32c859ae44ff803abb37cac99ac Gerrit-Change-Number: 11679 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 24 Oct 2018 05:23:14 +0000 Gerrit-HasComments: Yes