Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11827 )
Change subject: [compaction] Cleanup of compaction policy code ...................................................................... Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/11827/1/src/kudu/tablet/compaction_policy.h File src/kudu/tablet/compaction_policy.h: http://gerrit.cloudera.org:8080/#/c/11827/1/src/kudu/tablet/compaction_policy.h@a53 PS1, Line 53: Is this done, or just a non-goal now? Regardless, it'd probably be helpful for further compaction-enthusiasts to define it here or point to the appropriate design doc explaining what 'quality' is. http://gerrit.cloudera.org:8080/#/c/11827/1/src/kudu/tablet/compaction_policy.h@42 PS1, Line 42: Policy() = default; : virtual ~Co not needed? http://gerrit.cloudera.org:8080/#/c/11827/1/src/kudu/tablet/compaction_policy.cc File src/kudu/tablet/compaction_policy.cc: http://gerrit.cloudera.org:8080/#/c/11827/1/src/kudu/tablet/compaction_policy.cc@395 PS1, Line 395: computes some upper and lower bounds nit: ... of the quality score -- To view, visit http://gerrit.cloudera.org:8080/11827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I955ec66a510f04fd869f7d969a643e4d0f7f415f Gerrit-Change-Number: 11827 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 31 Oct 2018 06:36:43 +0000 Gerrit-HasComments: Yes
