Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11827 )
Change subject: [compaction] Cleanup of compaction policy code ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11827/3/src/kudu/tablet/compaction_policy.h File src/kudu/tablet/compaction_policy.h: http://gerrit.cloudera.org:8080/#/c/11827/3/src/kudu/tablet/compaction_policy.h@66 PS3, Line 66: std::numeric_limits<uint64_t>::max() > Ah, I see. Would it be a better choice making this method pure virtual? Done -- To view, visit http://gerrit.cloudera.org:8080/11827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I955ec66a510f04fd869f7d969a643e4d0f7f415f Gerrit-Change-Number: 11827 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 02 Nov 2018 16:07:26 +0000 Gerrit-HasComments: Yes
