Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11827 )
Change subject: [compaction] Cleanup of compaction policy code ...................................................................... Patch Set 3: (6 comments) Some nits, I didn't really looked at the essence of how compaction works. http://gerrit.cloudera.org:8080/#/c/11827/3/src/kudu/tablet/compaction_policy-test.cc File src/kudu/tablet/compaction_policy-test.cc: http://gerrit.cloudera.org:8080/#/c/11827/3/src/kudu/tablet/compaction_policy-test.cc@58 PS3, Line 58: unordered_set<const RowSet*> nit: introduce a typedef? http://gerrit.cloudera.org:8080/#/c/11827/3/src/kudu/tablet/compaction_policy.h File src/kudu/tablet/compaction_policy.h: http://gerrit.cloudera.org:8080/#/c/11827/3/src/kudu/tablet/compaction_policy.h@62 PS3, Line 62: size nit: size in bytes ? http://gerrit.cloudera.org:8080/#/c/11827/3/src/kudu/tablet/compaction_policy.h@66 PS3, Line 66: std::numeric_limits<uint64_t>::max() Are you sure this is not a functional change? http://gerrit.cloudera.org:8080/#/c/11827/3/src/kudu/tablet/compaction_policy.cc File src/kudu/tablet/compaction_policy.cc: http://gerrit.cloudera.org:8080/#/c/11827/3/src/kudu/tablet/compaction_policy.cc@53 PS3, Line 53: advanced As I understand, this change moves the flag into the non-experimental domain, meaning --unlock_experimental_flags no longer necessary to use it. Is that OK? http://gerrit.cloudera.org:8080/#/c/11827/3/src/kudu/tablet/compaction_policy.cc@374 PS3, Line 374: & style nit: stick the ampersand to the parameter type. http://gerrit.cloudera.org:8080/#/c/11827/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/11827/3/src/kudu/tablet/tablet.cc@2317 PS3, Line 2317: *o nit: maybe, dereference the pointer just once and use the result reference everywhere in the body of this method. -- To view, visit http://gerrit.cloudera.org:8080/11827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I955ec66a510f04fd869f7d969a643e4d0f7f415f Gerrit-Change-Number: 11827 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 31 Oct 2018 18:02:11 +0000 Gerrit-HasComments: Yes
