Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 )
Change subject: [examples] Add basic Spark example (scala) ...................................................................... Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/README.adoc File examples/scala/spark-example/README.adoc: http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/README.adoc@43 PS10, Line 43: KuduMasters > Java strings are case sensitive, so this should be kuduMasters, to correspo These are all fixed, but was awaiting feedback from Will/Grant on their previous naming conventions for these different variables. Will push them once I receive that feedback. http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/README.adoc@45 PS10, Line 45: SparkMaster > same as above - sparkMaster not SparkMaster Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/README.adoc@56 PS10, Line 56: KuduMasters > Same as above. This should be kuduMasters with lowercase k Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/README.adoc@57 PS10, Line 57: TableName > same as above - tableName, not TableName Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/README.adoc@63 PS10, Line 63: SparkMaste > same here sparkMaster Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/README.adoc@70 PS10, Line 70: -DKuduMasters=master.0:7051,master.1:7051,master.2:7051 -DTableName=test_table \ : -DSparkMaster=yarn > same comment here, you need to change the names of sys properties to match Done -- To view, visit http://gerrit.cloudera.org:8080/11788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ba09f0118c054a07b951e241c31d66245c57d3f Gerrit-Change-Number: 11788 Gerrit-PatchSet: 10 Gerrit-Owner: Mitch Barnett <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 31 Oct 2018 20:42:31 +0000 Gerrit-HasComments: Yes
