Mitch Barnett has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11788 )

Change subject: [examples] Add basic Spark example (scala)
......................................................................


Patch Set 11:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/11788/11/examples/scala/spark-example/README.adoc
File examples/scala/spark-example/README.adoc:

http://gerrit.cloudera.org:8080/#/c/11788/11/examples/scala/spark-example/README.adoc@32
PS11, Line 32: compile and
> remove
Done


http://gerrit.cloudera.org:8080/#/c/11788/11/examples/scala/spark-example/README.adoc@33
PS11, Line 33: spark-example/
> `spark-example` instead.
Done


http://gerrit.cloudera.org:8080/#/c/11788/11/examples/scala/spark-example/README.adoc@41
PS11, Line 41: There are a few Java system properties defined in 
SparkExample.scala:
             :
             : - kuduMasters: A comma-separated list of Kudu master addresses. 
Defaults to
             :   'localhost:7051'.
             : - tableName: The name of the table you wish to create on the 
Kudu cluster.
             :   Defaults to 'spark_test'.
             :
             : To run this as a spark2 'spark-submit' job, use the spark-submit 
command
             : as follows from the spark-example directory - it requires that 
you have built
             : and compiled the package using the 'mvn package' command above. 
You will also
             : need a Spark on YARN cluster and a Kudu cluster, both of which 
should be
             : resolvable and accessible from the host executing the command:
> I think we should redo this section a little bit. How do you like:
Done


http://gerrit.cloudera.org:8080/#/c/11788/11/examples/scala/spark-example/README.adoc@57
PS11, Line 57: <preferred deploy mode>
> What's the default? We want client mode so people will see the log messages
Yeah, the default is client. I've omitted this parameter.


http://gerrit.cloudera.org:8080/#/c/11788/11/examples/scala/spark-example/src/main/scala/org/apache/kudu/spark/examples/SparkExample.scala
File 
examples/scala/spark-example/src/main/scala/org/apache/kudu/spark/examples/SparkExample.scala:

http://gerrit.cloudera.org:8080/#/c/11788/11/examples/scala/spark-example/src/main/scala/org/apache/kudu/spark/examples/SparkExample.scala@65
PS11, Line 65: defaul
> default
Done



--
To view, visit http://gerrit.cloudera.org:8080/11788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ba09f0118c054a07b951e241c31d66245c57d3f
Gerrit-Change-Number: 11788
Gerrit-PatchSet: 11
Gerrit-Owner: Mitch Barnett <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Greg Solovyev <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Comment-Date: Fri, 02 Nov 2018 20:11:01 +0000
Gerrit-HasComments: Yes

Reply via email to