Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 )
Change subject: [examples] Add basic Spark example (scala) ...................................................................... Patch Set 11: (13 comments) http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/README.adoc File examples/scala/spark-example/README.adoc: http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/README.adoc@32 PS10, Line 32: To compile and build the example, ensure maven is installed and execute : the > Can you specify what you need for this to work? Do you need Spark running s Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/README.adoc@38 PS10, Line 38: $ mvn package > After poking around the internet for a bit, I think we shouldn't try to mak Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/README.adoc@43 PS10, Line 43: addr > Remove. Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/README.adoc@70 PS10, Line 70: > You can't break the line in the middle of a single-quotes literal, since ev Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/src/main/scala/org/apache/kudu/examples/SparkExample.scala File examples/scala/spark-example/src/main/scala/org/apache/kudu/examples/SparkExample.scala: http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/src/main/scala/org/apache/kudu/examples/SparkExample.scala@17 PS10, Line 17: > I think this should be org.apache.kudu.spark.examples. Renamed, and created the additional directory structure. http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/src/main/scala/org/apache/kudu/examples/SparkExample.scala@32 PS10, Line 32: > Spaces after commas here and elsewhere. Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/src/main/scala/org/apache/kudu/examples/SparkExample.scala@40 PS10, Line 40: > Define Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/src/main/scala/org/apache/kudu/examples/SparkExample.scala@44 PS10, Line 44: > nit: space here Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/src/main/scala/org/apache/kudu/examples/SparkExample.scala@47 PS10, Line 47: > nit: remove extra line Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/src/main/scala/org/apache/kudu/examples/SparkExample.scala@51 PS10, Line 51: > KuduSparkExample Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/src/main/scala/org/apache/kudu/examples/SparkExample.scala@54 PS10, Line 54: > Import Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/src/main/scala/org/apache/kudu/examples/SparkExample.scala@67 PS10, Line 67: > Let's do the default number of replicas (i.e. remove setting the number of Done http://gerrit.cloudera.org:8080/#/c/11788/10/examples/scala/spark-example/src/main/scala/org/apache/kudu/examples/SparkExample.scala@102 PS10, Line 102: > . Done -- To view, visit http://gerrit.cloudera.org:8080/11788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ba09f0118c054a07b951e241c31d66245c57d3f Gerrit-Change-Number: 11788 Gerrit-PatchSet: 11 Gerrit-Owner: Mitch Barnett <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 01 Nov 2018 19:37:12 +0000 Gerrit-HasComments: Yes
