Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 )
Change subject: [sentry] add AuthzProvider ...................................................................... Patch Set 10: -Code-Review (2 comments) http://gerrit.cloudera.org:8080/#/c/11659/10/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/11659/10/src/kudu/master/sentry_authz_provider.cc@84 PS10, Line 84: 1 nit: does the default setting of 1 seem good enough for the production use? Another question: is it possible to set this to some 'do not care' value but rely purely on the timeout settings instead? http://gerrit.cloudera.org:8080/#/c/11659/10/src/kudu/master/sentry_authz_provider.cc@117 PS10, Line 117: TAG_FLAG(sentry_service_max_message_size_bytes, advanced); : TAG_FLAG(sentry_service_max_message_size_bytes, experimental); : TAG_FLAG(sentry_service_max_message_size_bytes, runtime); > These only get set once when the AuthzProvider starts up; should the be non +1 Indeed, all these flags for the underlying thrift client do not qualify for runtime ones as it seems from the implementation. -- To view, visit http://gerrit.cloudera.org:8080/11659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I254828d640cd905e33dbaf0fe100d660bc9e6772 Gerrit-Change-Number: 11659 Gerrit-PatchSet: 10 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 01 Nov 2018 23:00:56 +0000 Gerrit-HasComments: Yes
