Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 )
Change subject: [sentry] add AuthzProvider ...................................................................... Patch Set 11: Code-Review+1 (2 comments) Sorry, a couple small nits and LGTM. http://gerrit.cloudera.org:8080/#/c/11659/11/src/kudu/master/authz_provider.h File src/kudu/master/authz_provider.h: http://gerrit.cloudera.org:8080/#/c/11659/11/src/kudu/master/authz_provider.h@63 PS11, Line 63: // Checks if retrieving table's metadata is authorized for the given user. nit: "metadata" seems like it might be a Sentry construct, which is fine, but I think it'd help to flesh this out a bit more. IMO it's not obvious from just reading this how and where this should be used. WDYT? Something like: // Checks if retrieving metadata about the table is authorized for the given user. // E.g. when checking for table presence or locations, checking the status of DDL operations, etc. http://gerrit.cloudera.org:8080/#/c/11659/11/src/kudu/master/sentry_authz_provider.h File src/kudu/master/sentry_authz_provider.h: http://gerrit.cloudera.org:8080/#/c/11659/11/src/kudu/master/sentry_authz_provider.h@39 PS11, Line 39: : // An implementation of AuthzProvider, which connects to the Sentry Service : // for authorization metadata and allow or deny the actions performed by : // users based on the metadata. nit: "An implementation of AuthzProvider that connects to Apache Sentry for authorization metadata and allows or denies actions performed by users based on the metadata." -- To view, visit http://gerrit.cloudera.org:8080/11659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I254828d640cd905e33dbaf0fe100d660bc9e6772 Gerrit-Change-Number: 11659 Gerrit-PatchSet: 11 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 02 Nov 2018 02:09:45 +0000 Gerrit-HasComments: Yes
