Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 )
Change subject: [sentry] add AuthzProvider ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/11659/11/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/11659/11/src/kudu/master/sentry_authz_provider.cc@246 PS11, Line 246: : // Validates the sentry_service_rpc_addresses gflag. : bool SentryAuthzProvider::ValidateAddresses(const char* flag_name, : const string& addresses) { : vector<HostPort> host_ports; : Status s = HostPort::ParseStringsWithScheme(addresses, SentryClient::kDefaultSentryPort, : &host_ports); : if (!s.ok()) { : LOG(ERROR) << "invalid flag " << flag_name << ": " << s.ToString(); : } : return s.ok(); : } Now that this is tested elsewhere, it doesn't need to be part of the class. Stick it in an anonymous namespace? -- To view, visit http://gerrit.cloudera.org:8080/11659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I254828d640cd905e33dbaf0fe100d660bc9e6772 Gerrit-Change-Number: 11659 Gerrit-PatchSet: 11 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 02 Nov 2018 04:48:12 +0000 Gerrit-HasComments: Yes
