Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11905 )
Change subject: [dist-test] build environment for tests in loop mode ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/11905/3/build-support/dist_test.py File build-support/dist_test.py: http://gerrit.cloudera.org:8080/#/c/11905/3/build-support/dist_test.py@534 PS3, Line 534: cular subset of tests provided by the binary. In that case it > I'll punt on this because from paranoid's point of view that looks fragile: Ack http://gerrit.cloudera.org:8080/#/c/11905/3/build-support/dist_test.py@537 PS3, Line 537: yield noise. To avoid this, we disable sharding in this case. : filter_flags = [e for e in options.args : if e.find("--gtest_filter") > It's necessary to get just one out of many if it's necessary to avoid shard Thanks for the comment! -- To view, visit http://gerrit.cloudera.org:8080/11905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I487194a396635bbaab457795bb24c0063eebbe5d Gerrit-Change-Number: 11905 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 08 Nov 2018 20:12:48 +0000 Gerrit-HasComments: Yes
