Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11905 )
Change subject: [dist-test] build environment for tests in loop mode ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/11905/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11905/3//COMMIT_MSG@10 PS3, Line 10: dest nit: dist http://gerrit.cloudera.org:8080/#/c/11905/3/build-support/dist_test.py File build-support/dist_test.py: http://gerrit.cloudera.org:8080/#/c/11905/3/build-support/dist_test.py@525 PS3, Line 525: tests_regex = "^" + os.path.basename(options.cmd) + "(\.[0-9]+)?$" nit: mind describing what this matches? http://gerrit.cloudera.org:8080/#/c/11905/3/build-support/dist_test.py@534 PS3, Line 534: e.find("--gtest_filter") == 0 or e.find("--gtest-filter") == 0 nit: I think you can do: [e for e in options.args if "--gtest_filter" in e or "--gtest-filter" in e] http://gerrit.cloudera.org:8080/#/c/11905/3/build-support/dist_test.py@537 PS3, Line 537: e = executions[0] : e.env["GTEST_TOTAL_SHARDS"] = 1 : e.env["GTEST_SHARD_INDEX"] = 0 What's special about the first execution? -- To view, visit http://gerrit.cloudera.org:8080/11905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I487194a396635bbaab457795bb24c0063eebbe5d Gerrit-Change-Number: 11905 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Comment-Date: Thu, 08 Nov 2018 18:21:44 +0000 Gerrit-HasComments: Yes
