Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11905 )
Change subject: [dist-test] build environment for tests in loop mode ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11905/2/build-support/dist_test.py File build-support/dist_test.py: http://gerrit.cloudera.org:8080/#/c/11905/2/build-support/dist_test.py@528 PS2, Line 528: # The presence of the --gtest_filter flag means running some particular test : # scenarios provided by the binary. In that case it doesn't make much sense : # to shard the execution since only the shards containing the matching tests : # scenarios would produce any meaningful results. Also, it's not trivial : # to point which particular scenario is run by particular shard anyway. : # So, simply disable sharding in that case. > Nit: reword? Maybe "The presence of the --gtest_filter flag means the user Done, thanks! -- To view, visit http://gerrit.cloudera.org:8080/11905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I487194a396635bbaab457795bb24c0063eebbe5d Gerrit-Change-Number: 11905 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 08 Nov 2018 16:59:21 +0000 Gerrit-HasComments: Yes
