Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12040 )
Change subject: java: add log4j.properties file to kudu-test-utils module ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12040/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12040/2//COMMIT_MSG@9 PS2, Line 9: This squelches a warning and allows logging to function for tests in What was the warning? You don't necessarily need to add it to the commit message; just curious so we know to look out for it in the future. http://gerrit.cloudera.org:8080/#/c/12040/2/java/kudu-test-utils/src/test/resources/log4j.properties File java/kudu-test-utils/src/test/resources/log4j.properties: http://gerrit.cloudera.org:8080/#/c/12040/2/java/kudu-test-utils/src/test/resources/log4j.properties@18 PS2, Line 18: log4j.rootLogger = WARN, out I took a look at the other instances: java/kudu-backup/src/test/resources/log4j.properties:log4j.rootLogger = WARN, out java/kudu-client/src/test/resources/log4j.properties:log4j.rootLogger = DEBUG, out java/kudu-hive/src/test/resources/log4j.properties:log4j.rootLogger = DEBUG, out java/kudu-spark-tools/src/test/resources/log4j.properties:log4j.rootLogger = WARN, out java/kudu-spark/src/test/resources/log4j.properties:log4j.rootLogger = WARN, out I imagine they should all be the same; which of WARN or DEBUG do you think is more appropriate? -- To view, visit http://gerrit.cloudera.org:8080/12040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635 Gerrit-Change-Number: 12040 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 06 Dec 2018 18:14:03 +0000 Gerrit-HasComments: Yes
