Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12040 )
Change subject: java: add log4j.properties file to kudu-test-utils module ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12040/3/java/kudu-test-utils/src/test/resources/log4j.properties File java/kudu-test-utils/src/test/resources/log4j.properties: http://gerrit.cloudera.org:8080/#/c/12040/3/java/kudu-test-utils/src/test/resources/log4j.properties@21 PS3, Line 21: %F:%L > Are you sure you want the logging file name and the line number of where th That is an interesting observation and something we should look at for Spark integrations etc but this is for tests so I'm not worried about it in this context. -- To view, visit http://gerrit.cloudera.org:8080/12040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635 Gerrit-Change-Number: 12040 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 20 Dec 2018 05:48:05 +0000 Gerrit-HasComments: Yes
