Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12040 )

Change subject: java: add log4j.properties file to kudu-test-utils module
......................................................................


Patch Set 3: Code-Review-1

I am inclined not to merge as-is, instead we should probably just add the one 
that is missing. What I see before this change is this:

mpercy@ve0518:~/src/kudu/java$ find . | grep xml | perl -pe 's/^..//; 
s{/.*}{};' | uniq
target
kudu_style.xml
kudu-test-utils
checkstyle_suppressions.xml
kudu-spark
kudu-hive
kudu-flume-sink
kudu-mapreduce
kudu-spark-tools
kudu-client
kudu-client-tools
kudu-backup

after this change I see this:

mpercy@ve0518:~/src/kudu/java$ find . | grep xml | perl -pe 's/^..//; 
s{/.*}{};' | uniq
target
kudu_style.xml
checkstyle_suppressions.xml
kudu-spark
kudu-client
kudu-backup

Obviously this change to the log4j.properties files is having unintended 
consequences. I am going to look into this a little more to try to understand 
what is going on.


--
To view, visit http://gerrit.cloudera.org:8080/12040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic57941d593c32d17c9619f51d18430a75e962635
Gerrit-Change-Number: 12040
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Comment-Date: Wed, 12 Dec 2018 01:50:43 +0000
Gerrit-HasComments: No

Reply via email to