Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12054

to look at the new patch set (#3).

Change subject: [build] Fix bulding codegen on MacOS Mojave
......................................................................

[build] Fix bulding codegen on MacOS Mojave

The codegen target uses clang-6.0 from thirdparty even on macOS, after
upgrading to macOS Mojave and Xcode 10 the build failed due to changes
in where the SDK is located.

Xcode 10's release notes claim the macOS headers are no longer installed
in the base system under /usr/include[1].

This commit makes CMake locate the headers using "xcrun --show-sdk-path"
and pass it to clang's sysroot.

[1] 
https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes

Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29
---
M src/kudu/codegen/CMakeLists.txt
1 file changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/12054/3
--
To view, visit http://gerrit.cloudera.org:8080/12054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29
Gerrit-Change-Number: 12054
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>

Reply via email to