Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12054 )

Change subject: [build] Fix bulding codegen on MacOS Mojave
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt
File src/kudu/codegen/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@74
PS3, Line 74:
> no, it seems it breaks stuff when the workaround is implemented (at least p
Hmm OK.


http://gerrit.cloudera.org:8080/#/c/12054/4/src/kudu/codegen/CMakeLists.txt
File src/kudu/codegen/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/12054/4/src/kudu/codegen/CMakeLists.txt@96
PS4, Line 96: # [1]
            : # 
https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes
Nit: combine onto one line:

  1. https://developer.apple.com/...


http://gerrit.cloudera.org:8080/#/c/12054/4/src/kudu/codegen/CMakeLists.txt@98
PS4, Line 98: (APPLE)
Don't need this inner set of parens.


http://gerrit.cloudera.org:8080/#/c/12054/4/src/kudu/codegen/CMakeLists.txt@105
PS4, Line 105:       ${IR_FLAGS}
             :       --sysroot="${SDKPATH}")
Nit: indentation (see L84).



--
To view, visit http://gerrit.cloudera.org:8080/12054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29
Gerrit-Change-Number: 12054
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Sat, 08 Dec 2018 00:25:22 +0000
Gerrit-HasComments: Yes

Reply via email to