Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12054 )
Change subject: [build] Fix bulding codegen on MacOS Mojave ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt File src/kudu/codegen/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@73 PS3, Line 73: endif() > Once this is working we'll need a big block comment here explaining what's Done http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@74 PS3, Line 74: > Isn't the below correct to do regardless of whether /usr/include exists? no, it seems it breaks stuff when the workaround is implemented (at least patch set #2 broke Grant's build and that was the difference) http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@82 PS3, Line 82: > I guess this is fine if it works, but isn't -I sufficient? I'm reading thro I tried with -I first and it didn't work that way for some reason. http://gerrit.cloudera.org:8080/#/c/12054/3/src/kudu/codegen/CMakeLists.txt@95 PS3, Line 95: # > If you go down the --sysroot path, I think I'd prefer adding it directly to Done -- To view, visit http://gerrit.cloudera.org:8080/12054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Gerrit-Change-Number: 12054 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 07 Dec 2018 20:57:40 +0000 Gerrit-HasComments: Yes
