helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 )
Change subject: KUDU-2636: LBM supports deleting dead and full containers ...................................................................... Patch Set 6: maybe that is not enough. please take a look at this case: two remaining LogBlocks are deleted in different LogBlockDeletionTransaction concurrently, then one will trigger hole punching and the other will trigger dead container removal. but it is not safe to access the container for hole punching when removing dead container is executed first. i think the key point is that the container point in 'all_containers_by_name_' is a raw point which will never be deleted after startup. in other words, the container point is not safe. i am going to use 'std::shared_ptr' and 'std::weak_ptr' to wrap it. what do you think? -- To view, visit http://gerrit.cloudera.org:8080/12075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d3672ae3c3dd9acd489120d653c44a641537f10 Gerrit-Change-Number: 12075 Gerrit-PatchSet: 6 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Thu, 20 Dec 2018 01:24:06 +0000 Gerrit-HasComments: No
