Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 )
Change subject: KUDU-2636: LBM supports deleting dead and full containers ...................................................................... Patch Set 11: I pushed a new revision with a few cleanups: - Properly rebased on top of the "wrapped up containers in scoped_refptr" change. - The few remaining DOS line endings converted to UNIX line endings. - A few formatting/style fixes. - The only real change was to get read_only handling right: in that case, we should not delete dead containers at startup. To do this I moved the call to TrySetDead into Repair(), and changed the container vector plumbing from OpenDataDir() into Repair() to pass containers by scoped_refptr instead of by name. Please take a look and let me know if anything seems wrong. -- To view, visit http://gerrit.cloudera.org:8080/12075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d3672ae3c3dd9acd489120d653c44a641537f10 Gerrit-Change-Number: 12075 Gerrit-PatchSet: 11 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Tue, 08 Jan 2019 20:36:23 +0000 Gerrit-HasComments: No
