Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12075 )

Change subject: KUDU-2636: LBM supports deleting dead and full containers
......................................................................


Patch Set 10:

> Something's not quite right with this patch; when I look at the full diff, I 
> see both the "wrapping up containers in scoped_refptr" patch as well as the 
> "deletion of dead/full containers" patch mixed together.

This is still the case as of PS10. Here's a workflow I like to use to resolve 
situations like these:
1) 'git checkout' a new branch based on master.
2) 'git cherry-pick' the scoped_refptr commit into this new branch.
3) 'git cherry-pick' this commit onto the new branch.
4) Step 3 will yield a lot of conflicts; manually resolve them.

When you're done, you should have a new branch with both patches in their 
desired state, and you can push the entirety of the new branch to gerrit.


--
To view, visit http://gerrit.cloudera.org:8080/12075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d3672ae3c3dd9acd489120d653c44a641537f10
Gerrit-Change-Number: 12075
Gerrit-PatchSet: 10
Gerrit-Owner: helifu <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: helifu <[email protected]>
Gerrit-Comment-Date: Mon, 07 Jan 2019 22:31:31 +0000
Gerrit-HasComments: No

Reply via email to