Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12054 )
Change subject: [build] Fix bulding codegen on MacOS Mojave ...................................................................... [build] Fix bulding codegen on MacOS Mojave The codegen target uses clang-6.0 from thirdparty even on macOS, after upgrading to macOS Mojave and Xcode 10 the build failed due to changes in where the SDK is located. Xcode 10's release notes claim the macOS headers are no longer installed in the base system under /usr/include[1]. This commit makes CMake locate the headers using "xcrun --show-sdk-path" and pass it to clang's sysroot. [1] https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Reviewed-on: http://gerrit.cloudera.org:8080/12054 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Attila Bukor <[email protected]> --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Attila Bukor: Verified -- To view, visit http://gerrit.cloudera.org:8080/12054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I33f7510c7bf0cc2a7708191653b23c04e6df8a29 Gerrit-Change-Number: 12054 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]>
