Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12119 )
Change subject: [blog] a blogpost about location awareness in Kudu ...................................................................... Patch Set 2: (46 comments) Thank you for the thorough review! http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md File _posts/2018-12-20-location-awareness.md: http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@7 PS1, Line 7: an overview > An overview is always high-level, so remove "high-level". Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@9 PS1, Line 9: principles of the design > principles of the design Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@11 PS1, Line 11: potential future enhancements and extensions > potential future enhancements and extensions Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@17 PS1, Line 17: the fo > for Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@17 PS1, Line 17: loc > Remove. Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@20 PS1, Line 20: In a Kudu cluster consisting of multiple servers s > In a Kudu cluster consisting of multiple servers spread over several racks Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@20 PS1, Line 20: ever > replicas Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@21 PS1, Line 21: that t > Remove. Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@21 PS1, Line 21: s > in Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@21 PS1, Line 21: place the > Remove. Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@21 PS1, Line 21: vailable : even if all the ser > Remove. Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@22 PS1, Line 22: > become Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@22 PS1, Line 22: ers in a single rack bec > even if all the servers Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@25 PS1, Line 25: among servers in the rack: network switch, power supply, etc. More generally, : replace 'rack' wit > Remove (redundant). Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@28 PS1, Line 28: lies to a datacenter if the network latency between datacenters : is low. > I don't think we need to use this concept very much so I wouldn't include i OK. I thought this might look easier to digest for people who know what fault domain is, but I agree we don't use the concept of fault domain in this post, so it's not necessary to include. http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@31 PS1, Line 31: > Remove. Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@31 PS1, Line 31: Locations in > nit: I prefer "More generally", but "To generalize" is ok. Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@31 PS1, Line 31: Locations in Kudu > Join this paragraph with the previous paragraph. Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@32 PS1, Line 32: === > Is a chassis a common term for something multiple servers would run on? To In big server farms, they sometimes have aggregates of physical hosts/nodes (sometimes hot-pluggable) which share common power, e.g.: https://ark.intel.com/products/81878/Intel-Server-Chassis-H2216XXKR2 (check the 'Product images' page to get a better idea how it looks like). Those are called 'chassis'. http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@32 PS1, Line 32: > Does a site differ from a datacenter? Site might mean a sub-unit in a datacenter (e.g., a server room in a big datacenter). http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@33 PS1, Line 33: a string that begins with a slash (`/`) and : consists of slash-separated tokens each of which contains only characters from : the set `[a-zA-Z0-9_-.]`. The components > Rephrase this more positively: "This even applies to a datacenter if the ne I like that positive attitude :) http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@37 PS1, Line 37: deployed cluster, e.g. `/dc-0/rack-09/host-01`. As of now, Kudu does not : exploit the hierarchical > I'm not sure what our publishing schedule is, but I think we ought not publ OK, I removed this sentence and we can add information on the version once the release is cut. http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@49 PS1, Line 49: registers > to exploit Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@49 PS1, Line 49: d b > to establish Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@50 PS1, Line 50: r is used to make tablet replica placement decisions, > I think it's just HDFS. Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@57 PS1, Line 57: tic, at least > Actually all masters assign a location, but it's the leader master's locati OK, I rephrased this accordingly. http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@57 PS1, Line 57: agno > The Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@57 PS1, Line 57: ssi > to Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@57 PS1, Line 57: so the > a location Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@57 PS1, Line 57: not reported back > when it registers Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@58 PS1, Line 58: ormation interna > Remove. Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@58 PS1, Line 58: use the > the location Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@59 PS1, Line 59: > the Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@60 PS1, Line 60: in case if all tablet servers in a si > Remove. Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@60 PS1, Line 60: t > the corresponding Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@62 PS1, Line 62: ocation as well, so the clients can ma > the tablet server re-registers, which only occurs if the master or tablet s Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@62 PS1, Line 62: informed : decisions when they about to connect to the closest tablet server. : > nit: I would rephrase as "Kudu tablet servers are location agnostic, at lea Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@64 PS1, Line 64: > . Masters Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@65 PS1, Line 65: master assigns location for a client when it connects > Ditto. Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@65 PS1, Line 65: The Kudu l > Explain how, briefly (maybe by just pointing the reader to the section belo Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@67 PS1, Line 67: to the client along with other cluster-specific information. : : : How to make Kudu cluster location-aware > I think this is too detailed, but if you want to include it mention the `Co I removed the details. http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@73 PS1, Line 73: ion_mapping_cmd` flag for Kudu ma > Swap these two words. Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@76 PS1, Line 76: mappings stay the same regardless of the node where the location assignment > Does this paragraph belong in the next section? It repeats part of it. Yup, indeed -- that's some variation of the paragraph below. Good catch! http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@84 PS1, Line 84: r in a si > My preference is to use the word "three", not the symbol "3", but either is Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@97 PS1, Line 97: priority than conforming to the replica placement policies. In other words, > I'd first restate that re-replication and the placement of new replicas att Done http://gerrit.cloudera.org:8080/#/c/12119/1/_posts/2018-12-20-location-awareness.md@113 PS1, Line 113: s > are Done -- To view, visit http://gerrit.cloudera.org:8080/12119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I10b30a80d5661fb889a11285b8118cdea1a87cd2 Gerrit-Change-Number: 12119 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 28 Dec 2018 23:26:03 +0000 Gerrit-HasComments: Yes
