Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12119 )
Change subject: [blog] a blogpost about location awareness in Kudu ...................................................................... Patch Set 4: (18 comments) http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md File _posts/2018-12-20-location-awareness.md: http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@50 PS4, Line 50: the http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@55 PS4, Line 55: location string for the specified IP address/hostname. : The Is this meant to be a paragraph break? http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@61 PS4, Line 61: try to try http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@61 PS4, Line 61: the replica replicas http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@62 PS4, Line 62: if Remove. http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@62 PS4, Line 62: keep to keep http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@64 PS4, Line 64: as well Remove, or remove "Also". http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@65 PS4, Line 65: about to connect to the closest tablet server I'd say "attempt to read from the closest tablet server" since that's all we actually use it for. http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@67 PS4, Line 67: The Kudu leader master assigns location for a client when it connects to a : cluster. The assigned location string is sent back from the leader master : to the client along with other cluster-specific information. This is redundant with the previous paragraph. http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@84 PS4, Line 84: a http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@92 PS4, Line 92: placement policies I prefer to say "placement policy" singular since we only have one. Also I think you ought to define the placement policy here (i.e. restate the "use case" from the beginning as the placement policy). http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@94 PS4, Line 94: The automatic re-replication and the initial placement of new replicas both : attempt to spread replicas across locations so that the failure of tablet : servers in one location does not make tablets unavailable. This is basically the placement policy, so I'd just make it clear that "placement policy" is referring to this condition. http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@101 PS4, Line 101: policies Here and below, like I said, I prefer "policy" since we have just one. http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@139 PS4, Line 139: location each location http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@142 PS4, Line 142: Examples This section is really nice. Thanks for adding it. http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@147 PS4, Line 147: squares nit: rectangles or boxes http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@181 PS4, Line 181: result resulting http://gerrit.cloudera.org:8080/#/c/12119/4/_posts/2018-12-20-location-awareness.md@188 PS4, Line 188: land receive -- To view, visit http://gerrit.cloudera.org:8080/12119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I10b30a80d5661fb889a11285b8118cdea1a87cd2 Gerrit-Change-Number: 12119 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 24 Jan 2019 18:57:47 +0000 Gerrit-HasComments: Yes
