Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12119 )
Change subject: [blog] a blogpost about location awareness in Kudu ...................................................................... Patch Set 3: (1 comment) > (1 comment) > > > We have this script which we use for testing: > > https://github.com/apache/kudu/blob/master/src/kudu/scripts/assign-location.py > > While that script is awesome for testing it's a really bad example > for users because it doesn't actually assign locations based on the > network topology. We should make a small example that assigns > locations based on common subnet or something like that. SGTM. I agree it's better to have something that closer reflects the reality. After some consideration, I think out test scripts might be really confusing for people trying to understand what it's all about. > > > Maybe, I should put some TODO in the text as a reminder? > > Good idea. Just make it a comment. Done. http://gerrit.cloudera.org:8080/#/c/12119/2/_posts/2018-12-20-location-awareness.md File _posts/2018-12-20-location-awareness.md: http://gerrit.cloudera.org:8080/#/c/12119/2/_posts/2018-12-20-location-awareness.md@37 PS2, Line 37: `/dc-0/rack-09/host-01` > This isn't a good example location because it would place the host in its o Done -- To view, visit http://gerrit.cloudera.org:8080/12119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I10b30a80d5661fb889a11285b8118cdea1a87cd2 Gerrit-Change-Number: 12119 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Sat, 19 Jan 2019 04:48:21 +0000 Gerrit-HasComments: Yes
