Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12176 )
Change subject: tablet: clean up MergeIterState API ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12176/2/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/12176/2/src/kudu/common/generic_iterators.cc@159 PS2, Line 159: Status MergeIterState::Advance() { This is copy-pasted out of the class declaration. No changes except the noted member variable renames and removal of the else-after-return previously on L108 due to being flagged by clang-tidy. http://gerrit.cloudera.org:8080/#/c/12176/2/src/kudu/common/generic_iterators.cc@178 PS2, Line 178: Status MergeIterState::PullNextBlock() { This is literally copy-pasted out of the class declaration; no changes except as required by the member variable renames. -- To view, visit http://gerrit.cloudera.org:8080/12176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f821dc06ddbe3f7ef018eec15b1993cde7e7e0 Gerrit-Change-Number: 12176 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 08 Jan 2019 02:06:15 +0000 Gerrit-HasComments: Yes
