Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12176 )
Change subject: tablet: clean up MergeIterState API ...................................................................... tablet: clean up MergeIterState API This patch simply adds documentation and some readability cleanup to MergeIterState, which is a helper class for the MergeIterator. Non-API changes: - Add API docs to all public methods. - Extract the implementation of Advance() and PullNextBlock() out of the class declaration to make the API contract easier to quickly read and understand. - Rename a couple of private variables to clarify row-oriented semantics. API cleanup: - Add a public Init() method that delegates to PullNextBlock(). - Make PullNextBlock() and IsBlockExhausted() private methods. - Replace exposure of the underlying iterator via iter() with a public AddStats() method, since stats collection was the only use of iter(). There are no functional changes in this patch. Change-Id: Ie3f821dc06ddbe3f7ef018eec15b1993cde7e7e0 Reviewed-on: http://gerrit.cloudera.org:8080/12176 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/common/generic_iterators.cc 1 file changed, 89 insertions(+), 64 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie3f821dc06ddbe3f7ef018eec15b1993cde7e7e0 Gerrit-Change-Number: 12176 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]>
