Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12176 )
Change subject: tablet: clean up MergeIterState API ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12176/3/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/12176/3/src/kudu/common/generic_iterators.cc@126 PS3, Line 126: // Exposed for optimization purposes. I don't understand this part. We use remaining_in_block() to resize the client's RowBlock; isn't that necessary for correctness? -- To view, visit http://gerrit.cloudera.org:8080/12176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f821dc06ddbe3f7ef018eec15b1993cde7e7e0 Gerrit-Change-Number: 12176 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 08 Jan 2019 18:55:16 +0000 Gerrit-HasComments: Yes
