Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 )
Change subject: [tools] Add table scan tool ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12167/4/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/12167/4/src/kudu/tools/tool_action_table.cc@81 PS4, Line 81: '[', '(', '=', ')' or ']'" > I find these really confusing. For example, in the sample from the help mes yea, I was thinking the same thing -- rather than inventing a new syntax, I think a JSON representation of a parsed expression (AST-alike) would be much easier to reason about. Plus, we don't need to worry about implementing a parser :) For example, ["and", ["<", "key", 123], ["notnull", "col2"]]. It sort of ends up being a lisp dialect, proving out Greenspun's tenth rule -- To view, visit http://gerrit.cloudera.org:8080/12167 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieac340b70a9eaf131f82a2b7d61336211d1d48f8 Gerrit-Change-Number: 12167 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 08 Jan 2019 22:22:43 +0000 Gerrit-HasComments: Yes
