Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12194 )
Change subject: Eliminate redundant VLOG_IS_ON calls ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12194/2/src/kudu/util/logging-test.cc File src/kudu/util/logging-test.cc: http://gerrit.cloudera.org:8080/#/c/12194/2/src/kudu/util/logging-test.cc@257 PS2, Line 257: if (VLOG_IS_ON(1)) { : LOG(INFO) << "Test skipped: verbose level is at least 1"; : return; : } > I think you can manually reset the verbose level with FLAGS_v. Or is that i This seems like the easiest thing and it covers both cases, so I want to stick with it. -- To view, visit http://gerrit.cloudera.org:8080/12194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0781e64f95e33fe067f9f3e65e77aec8654f4ba3 Gerrit-Change-Number: 12194 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 23:13:10 +0000 Gerrit-HasComments: Yes
