Will Berkeley has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/12194 )
Change subject: Eliminate redundant VLOG_IS_ON calls
......................................................................
Eliminate redundant VLOG_IS_ON calls
In an expression like
VLOG(3) << Substitute("Your $0 is $1", expensive_foo(), costly_bar());
The expression on the righthand side of the << operator is evaluated
only when VLOG_IS_ON(3) is true. However, there were some cases of
defensive programming like
if (VLOG_IS_ON(3)) {
VLOG(3) << Substitute("Your $0 is $1", expensive_foo(), costly_bar());
}
with a redundant call to VLOG_IS_ON. This patch removes such cases as I
found from a simple review of all VLOG_IS_ON callsites. I also sometimes
transformed VLOG messages from a chain of <<'s to calls to Substitute.
This patch contains no functional changes.
Change-Id: I0781e64f95e33fe067f9f3e65e77aec8654f4ba3
Reviewed-on: http://gerrit.cloudera.org:8080/12194
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <[email protected]>
---
M src/kudu/client/batcher.cc
M src/kudu/clock/hybrid_clock.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/raft_consensus.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet-test-util.h
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_history_gc-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/logging-test.cc
11 files changed, 75 insertions(+), 61 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0781e64f95e33fe067f9f3e65e77aec8654f4ba3
Gerrit-Change-Number: 12194
Gerrit-PatchSet: 5
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
