Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12276 )
Change subject: [java] deflake RYW tests in TestKuduClient ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12276/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/12276/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@1084 PS1, Line 1084: // never go down from what previously observed, to ensure subsequent : // reads will not "go back in time" regarding writes that other : // clients have done. : for (int k = 0; k < 3; k++) { : AsyncKuduScanner scanner = asyncKuduClient.newScannerBuilder(table) : .readMode(AsyncKuduScanner.ReadMode.READ_YO > I don't see anything in this block of code that would cause the client's la Actually after more thoughts, this structure of the test is actually not right. The same client is being used concurrently (that is why there is concurrent update to LastPropagatedTimestamp), while it aims to test multiple clients. I will correct it. http://gerrit.cloudera.org:8080/#/c/12276/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@1090 PS1, Line 1090: .replicaSelection(replicaSelection) : .build(); > Should this test preTs instead of a new call to getLastPropagatedTimestamp? Done -- To view, visit http://gerrit.cloudera.org:8080/12276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I951abb9197f7e6b6a4c70cdf89948206840ddeda Gerrit-Change-Number: 12276 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 27 Jan 2019 20:54:55 +0000 Gerrit-HasComments: Yes
