Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12276 )
Change subject: [java] deflake RYW tests in TestKuduClient ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/12276/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12276/3//COMMIT_MSG@13 PS3, Line 13: It turns out to be a test only issue, which due to incorrect structure > OK, so if I'm understanding this correctly, the intent of the test was alwa The distinction is important because we want to ensure a single client can preserve read-your-writes and read-your-reads session guarantees even there is concurrent reads/writes performed by other clients. http://gerrit.cloudera.org:8080/#/c/12276/3//COMMIT_MSG@15 PS3, Line 15: wa > Nit: 'was' Done http://gerrit.cloudera.org:8080/#/c/12276/3//COMMIT_MSG@18 PS3, Line 18: concurrent reads/writes performed by other clients > I presume this is still true with the new version of the test? Do you know Right, it passed with the new version. Sorry that I added the line which closed the client at the wrong place (https://gerrit.cloudera.org/#/c/12276/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@1108) after I looped the second version... -- To view, visit http://gerrit.cloudera.org:8080/12276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I951abb9197f7e6b6a4c70cdf89948206840ddeda Gerrit-Change-Number: 12276 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 28 Jan 2019 20:08:57 +0000 Gerrit-HasComments: Yes
