Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12276 )
Change subject: [java] deflake RYW tests in TestKuduClient ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/12276/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12276/3//COMMIT_MSG@13 PS3, Line 13: It turns out to be a test only issue, which due to incorrect structure OK, so if I'm understanding this correctly, the intent of the test was always to test multiple clients, and it was a mistake for the test to share a single client the way it did? Could you explain why the distinction is important, based on RYW semantics? http://gerrit.cloudera.org:8080/#/c/12276/3//COMMIT_MSG@15 PS3, Line 15: is Nit: 'was' http://gerrit.cloudera.org:8080/#/c/12276/3//COMMIT_MSG@18 PS3, Line 18: With the fix, 0/1000 runs of TestKuduClient failed. I presume this is still true with the new version of the test? Do you know why the test also passed 1000 times in PS2? -- To view, visit http://gerrit.cloudera.org:8080/12276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I951abb9197f7e6b6a4c70cdf89948206840ddeda Gerrit-Change-Number: 12276 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 28 Jan 2019 19:41:06 +0000 Gerrit-HasComments: Yes
