Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12325 )
Change subject: [build] Add a script to publish the kudu-binary jars ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12325/1/build-support/mini-cluster/publish_mini_cluster_binaries.sh File build-support/mini-cluster/publish_mini_cluster_binaries.sh: http://gerrit.cloudera.org:8080/#/c/12325/1/build-support/mini-cluster/publish_mini_cluster_binaries.sh@67 PS1, Line 67: # Parse the command line parameters. > Enhanced getopt requires `brew install gnu-getopt` on Mac. Given this is a macOS continues to disappoint. I agree with your conclusion. http://gerrit.cloudera.org:8080/#/c/12325/2/build-support/mini-cluster/publish_mini_cluster_binaries.sh File build-support/mini-cluster/publish_mini_cluster_binaries.sh: http://gerrit.cloudera.org:8080/#/c/12325/2/build-support/mini-cluster/publish_mini_cluster_binaries.sh@116 PS2, Line 116: if [[ -z $(which mvn) ]]; then May want to pipe stderr/stdout into /dev/null; we don't need to see the result in stdout. http://gerrit.cloudera.org:8080/#/c/12325/2/build-support/mini-cluster/publish_mini_cluster_binaries.sh@202 PS2, Line 202: if [[ "$JAR_VERSION" != "$VERSION" ]]; then : echo "The version ($VERSION) doesn't match the jar's artifact.version property ($JAR_VERSION)" : exit 1 : fi Maybe we should do this before publishing anything, so that if it fails, we won't have a partial publish? -- To view, visit http://gerrit.cloudera.org:8080/12325 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83fe6b81ef70ec75b10f66fa8582a861daf285e4 Gerrit-Change-Number: 12325 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 31 Jan 2019 23:29:44 +0000 Gerrit-HasComments: Yes
