Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12325 )
Change subject: [build] Add a script to publish the kudu-binary jars ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12325/2/build-support/mini-cluster/publish_mini_cluster_binaries.sh File build-support/mini-cluster/publish_mini_cluster_binaries.sh: http://gerrit.cloudera.org:8080/#/c/12325/2/build-support/mini-cluster/publish_mini_cluster_binaries.sh@116 PS2, Line 116: if [[ -z $(which mvn) ]]; then > When I run this I don't see the result in stdout. I suppose it would print So on Ubuntu 18 here's what I see: $ which doesnotexist $ which ls /bin/ls $ which ls 2>/dev/null /bin/ls In short: - Running `which` on a non-existent binary prints nothing but exits with a non-zero status. - Running `which` on an existent binary prints the binary's path to stdout. I'm not concerned about `which` itself not existing; it should be standard on just about every UNIX system. It's disappointing (again) that macOS and Linux have opposite behaviors with respect to printing. -- To view, visit http://gerrit.cloudera.org:8080/12325 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83fe6b81ef70ec75b10f66fa8582a861daf285e4 Gerrit-Change-Number: 12325 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 01 Feb 2019 19:26:31 +0000 Gerrit-HasComments: Yes
