Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12325 )
Change subject: [build] Add a script to publish the kudu-binary jars ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12325/2/build-support/mini-cluster/publish_mini_cluster_binaries.sh File build-support/mini-cluster/publish_mini_cluster_binaries.sh: http://gerrit.cloudera.org:8080/#/c/12325/2/build-support/mini-cluster/publish_mini_cluster_binaries.sh@116 PS2, Line 116: PROP_FILE="META-INF/apache-kudu-test-binary.properties" > May want to pipe stderr/stdout into /dev/null; we don't need to see the res When I run this I don't see the result in stdout. I suppose it would print if `which` wasn't found. But I think that's worth printing as we expect every dev environment to have `which`. http://gerrit.cloudera.org:8080/#/c/12325/2/build-support/mini-cluster/publish_mini_cluster_binaries.sh@202 PS2, Line 202: : : : > Maybe we should do this before publishing anything, so that if it fails, we I don't that's worth the script complexity. On the very rare case this happens a partial upload is okay. Given these jars need to be generated for multiple operating systems, we will likely be uploading the jars to the staging repository one at a time regardless. In the future Docker may generate all the jars, but the OSX jar still needs to be created on a physical machine. -- To view, visit http://gerrit.cloudera.org:8080/12325 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83fe6b81ef70ec75b10f66fa8582a861daf285e4 Gerrit-Change-Number: 12325 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 01 Feb 2019 17:06:17 +0000 Gerrit-HasComments: Yes
