Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12363
Change subject: [WIP] KUDU-1868 Part 2: Eliminate socket read timeout except for negotiation ...................................................................... [WIP] KUDU-1868 Part 2: Eliminate socket read timeout except for negotiation This removes all use of socket read timeouts from the Java client and deprecates all public APIs involving the socket read timeout. The Java client does not use socket read timeouts anymore except to time out negotiation. This is OK because negotiation is the only activity on the socket when negotiation occurs. Once negotiation succeeds, the socket read timeout handler is removed from the pipeline, and the timeout tasks from Part 1 handle RPC timeouts. I didn't want to expose an API to set the negotiation timeout because it didn't seem useful, so I set the timeout to 10000ms, which is much larger than the default for the C++ client, which is 3000ms and also is not configurable. I wrote a test case and checked that negotiation did time out when the constant was lowered to a small number for the purposes of the test. WIP because need to finish deprecating some APIs cleanly. Change-Id: I391374dd72b6f4a91a9f69cf34758703afbdc59e --- M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/CommandLineParser.java M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduReadOptions.scala M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala 12 files changed, 39 insertions(+), 93 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/12363/1 -- To view, visit http://gerrit.cloudera.org:8080/12363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I391374dd72b6f4a91a9f69cf34758703afbdc59e Gerrit-Change-Number: 12363 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]>
