Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12363 )
Change subject: KUDU-1868 Part 2: Eliminate socket read timeout except for negotiation ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12363/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12363/4//COMMIT_MSG@19 PS4, Line 19: so I set the timeout to 10000ms, which is much larger than the default : for the C++ client Not clear why you used 10s and not 3s if that's what the C++ client uses; why not make the clients consistent? http://gerrit.cloudera.org:8080/#/c/12363/4/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java: http://gerrit.cloudera.org:8080/#/c/12363/4/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java@90 PS4, Line 90: localAsyncClient = new AsyncKuduClient.AsyncKuduClientBuilder(harness.getMasterAddressesAsString()) : .build(); : localClient = new KuduClient(localAsyncClient); Don't need this anymore; just use the client that's provided by the harness. -- To view, visit http://gerrit.cloudera.org:8080/12363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I391374dd72b6f4a91a9f69cf34758703afbdc59e Gerrit-Change-Number: 12363 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 12 Feb 2019 20:54:07 +0000 Gerrit-HasComments: Yes
