Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12363 )
Change subject: KUDU-1868 Part 2: Eliminate socket read timeout except for negotiation ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/12363/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/12363/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@1043 PS2, Line 1043: public long getDefaultSocketReadTimeoutMs() { please add the @Deprecated annotation to the method http://gerrit.cloudera.org:8080/#/c/12363/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@1044 PS2, Line 1044: LOG.warn("getDefaultSocketReadTimeoutMs is deprecated"); I think warn is unnecessary here, how about info? That way people can easily tune their log4j config to ignore this potentially disruptive spam in the logs. Here and elsewhere. http://gerrit.cloudera.org:8080/#/c/12363/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2477 PS2, Line 2477: public AsyncKuduClientBuilder defaultSocketReadTimeoutMs(long timeoutMs) { add @Deprecated annotation http://gerrit.cloudera.org:8080/#/c/12363/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java: http://gerrit.cloudera.org:8080/#/c/12363/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java@477 PS2, Line 477: public KuduClientBuilder defaultSocketReadTimeoutMs(long timeoutMs) { @Deprecated http://gerrit.cloudera.org:8080/#/c/12363/2/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/CommandLineParser.java File java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/CommandLineParser.java: http://gerrit.cloudera.org:8080/#/c/12363/2/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/CommandLineParser.java@93 PS2, Line 93: public long getSocketReadTimeoutMs() { @Deprecated -- To view, visit http://gerrit.cloudera.org:8080/12363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I391374dd72b6f4a91a9f69cf34758703afbdc59e Gerrit-Change-Number: 12363 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 07 Feb 2019 07:50:54 +0000 Gerrit-HasComments: Yes
