Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12409 )
Change subject: [Java] Add setRow to Operation ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12409/1//COMMIT_MSG Commit Message: PS1: Not really understanding the motivation. You provided some sample code near setRow(), but can you put it in context? When is this useful? http://gerrit.cloudera.org:8080/#/c/12409/1/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java File java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java: http://gerrit.cloudera.org:8080/#/c/12409/1/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java@188 PS1, Line 188: tables table's http://gerrit.cloudera.org:8080/#/c/12409/1/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java@201 PS1, Line 201: Preconditions.checkArgument(row.getSchema().equals(table.getSchema()), : "The row's schema must be equal to the table schema"); Won't this be expensive when working with many operations? -- To view, visit http://gerrit.cloudera.org:8080/12409 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7adee20166e90249209e80700db315172669edb5 Gerrit-Change-Number: 12409 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 13 Feb 2019 00:25:06 +0000 Gerrit-HasComments: Yes
