Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12409 )

Change subject: [Java] Add setRow to Operation
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12409/1/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java:

http://gerrit.cloudera.org:8080/#/c/12409/1/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java@201
PS1, Line 201:     Preconditions.checkArgument(row.getSchema() == 
table.getSchema(),
             :         "The row's schema must be equal by reference to the ta
> There is a cost, but it's pretty low given they need to be equal by referen
Ah, I assumed Schema had an overridden equals() that behaved like its C++ 
equivalent.



--
To view, visit http://gerrit.cloudera.org:8080/12409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7adee20166e90249209e80700db315172669edb5
Gerrit-Change-Number: 12409
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 17:35:29 +0000
Gerrit-HasComments: Yes

Reply via email to