Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12415 )
Change subject: Schema copy and move constructors/operators must copy max_col_id_ ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12415/3/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/12415/3/src/kudu/common/schema.cc@196 PS3, Line 196: name_to_index_(/*bucket_count*/ 10, > Nit: stylistically, I don't think this change brings us closer to style adh I think /*foo=*/ specifically triggers clang-tidy into checking that the parameter name does in fact match what you're telling it. So, as long as we think all our C++ libraries agree on this parameter name, this is expected -- To view, visit http://gerrit.cloudera.org:8080/12415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61b8df1142dc733c446a5717ca8cae1309f3e867 Gerrit-Change-Number: 12415 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 13 Feb 2019 04:33:06 +0000 Gerrit-HasComments: Yes
