Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 )
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list' ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet.proto File src/kudu/tablet/tablet.proto: http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet.proto@104 PS1, Line 104: bytes > Curious, why bytes and not string? Directory and file names can be damn near anything in *nix, IIRC. Protobuf strings must be UTF-8. http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet_replica.cc File src/kudu/tablet/tablet_replica.cc: http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet_replica.cc@448 PS1, Line 448: -- > nit: prepend a space ? http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tools/kudu-tool-test.cc@1892 PS1, Line 1892: ExternalMiniClusterOptions opts; > You can set num_data_dirs to something more interesting to test the multi-d Done http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tools/kudu-tool-test.cc@1910 PS1, Line 1910: : // Some fields like state or estimated on disk size may vary. Just check a : // few whose values we should know exactly. : ASSERT_STR_CONTAINS(stdout, : Substitute("Tablet id: $0", tablet_status.tablet_id())); : ASSERT_STR_CONTAINS(stdout, : Substitute("Table name: $0", workload.table_name())); : ASSERT_STR_CONTAINS(stdout, : Substitute("Data dirs: $0", JoinStrings(tablet_status.data_dirs(), ", "))); > Could you also tombstone the replica and run this? Done -- To view, visit http://gerrit.cloudera.org:8080/12449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633 Gerrit-Change-Number: 12449 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 14 Feb 2019 20:34:55 +0000 Gerrit-HasComments: Yes
