Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 )
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list' ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tablet/tablet_replica.cc File src/kudu/tablet/tablet_replica.cc: http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tablet/tablet_replica.cc@448 PS2, Line 448: // an empty 'data_dirs' in this case-- the state and last status will inform nit: add a separating space http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tools/kudu-tool-test.cc@1898 PS2, Line 1898: workload.set_num_tablets(kNumTablets); nit: add const ? http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tools/kudu-tool-test.cc@1901 PS2, Line 1901: : TServerDetails* ts = ts_map_[cluster_->tablet_server(0)->uuid()]; : vector<ListTabletsResponsePB::StatusAndSchemaPB> tablets; : ASSERT_OK(WaitForNumTabletsOnTS(ts, kNumTablets, kTim nit: if you do std:move(opts), maybe move all the related code under a scope? That's to avoid re-using invalidated opts below in case of modifications, etc. http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tools/kudu-tool-test.cc@1923 PS2, Line 1923: TEST_F(ToolTest, TestLocalReplicaDelete) { : NO_FATALS(StartMiniCluster()); : : // TestWorkLoad.Setup() internally generates a table. : TestWorkload workload(mini_cluster_.get()); : workload.set_num_replicas(1); nit: if that info is exactly the same in both alive and tombstoned tablet, maybe create a functor and use it instead of duplicating the code? -- To view, visit http://gerrit.cloudera.org:8080/12449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633 Gerrit-Change-Number: 12449 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 15 Feb 2019 03:56:35 +0000 Gerrit-HasComments: Yes
