Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12449 )
Change subject: [tools] Add tablet data dirs to 'kudu remote replica list' ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet.proto File src/kudu/tablet/tablet.proto: http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet.proto@104 PS1, Line 104: bytes > Directory and file names can be damn near anything in *nix, IIRC. Protobuf Ah, good to know. http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet_replica.cc File src/kudu/tablet/tablet_replica.cc: http://gerrit.cloudera.org:8080/#/c/12449/1/src/kudu/tablet/tablet_replica.cc@448 PS1, Line 448: -- > ? Minor grammar point, I've usually seen "--" used as: "in this case -- the state" http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/12449/2/src/kudu/tools/kudu-tool-test.cc@1940 PS2, Line 1940: JoinStrings(tablet_status.data_dirs(), ", " Hrm, surprised this is the case. I would have thought the tombstone would have no data and hence no data dir group. -- To view, visit http://gerrit.cloudera.org:8080/12449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e509b5c080a76a4110a32ecc073418c28aa0633 Gerrit-Change-Number: 12449 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 14 Feb 2019 22:46:44 +0000 Gerrit-HasComments: Yes
